Provide a better error message for failed library loads on jdk17+ #17374
Conversation
It only applies to jdk17+. jdk17 changed how JNI libraries are loaded, making this change necessary. jdk11 uses OpenJ9 to load libraries, which already provides the better error messages. |
|
Pushed a change to address the other review comments. |
| /* jdk17+ calls JVM_LoadLibrary with decorated library names. If the following is done | ||
| * then it overwrites the real error with a failure to load "liblib<name>.so.so". | ||
| */ |
There was a problem hiding this comment.
Actually, we don't expect this function to be used at all prior to jdk17; I'll plan to create a follow-up PR that simply asserts that and remove unnecessary code.
There was a problem hiding this comment.
Careful, I only checked jdk11.
There was a problem hiding this comment.
It won't be easy to check IBM Java 8.
There was a problem hiding this comment.
We can use defined(OPENJ9_BUILD) to avoid impacting IBM Java 8 builds.
|
Jenkins compile win32 jdk8 |
|
Jenkins compile alinux64 jdk17 |
|
I'm not sure whether to expect the jdk8 build to fail because |
pshipton
force-pushed
the
loaderror
branch
5 times, most recently
from
615a5d7
to
007c7eb
Compare
JVM_LoadLibrary() is used to load JNI libraries from jdk17. Issue eclipse-openj9#17285 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Jenkins compile win32 jdk8 |
|
Jenkins compile amac jdk17 |
JVM_LoadLibrary() is used to load JNI libraries from jdk17.
Fixes #17285
The library being loaded needs to exist to get the better message. With this change you get an error message to explain why the load failed.
Exception in thread "main" java.lang.UnsatisfiedLinkError: Failed to load library ("/home/pete/openj9-openjdk-jdk17/build/linux-x86_64-server-release/images/jdk/lib/libabc.so") /home/pete/openj9-openjdk-jdk17/build/linux-x86_64-server-release/images/jdk/lib/libabc.so: file too shortException in thread "main" java.lang.UnsatisfiedLinkError: Failed to load library ("/home/pete/openj9-openjdk-jdk17/build/linux-x86_64-server-release/images/jdk/lib/libabc.so") /home/pete/openj9-openjdk-jdk17/build/linux-x86_64-server-release/images/jdk/lib/libabc.so: invalid ELF header