[Jtreg/FFI/0.39] Remove the null segment check for pointer #17414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes aim to address the cases of the invalid passed-in arguments in downcall and the invalid return value from upcall by leveraging the exception handling code in upcall. Fixes: eclipse-openj9#16761 Conflicts: runtime/vm/UpcallVMHelpers.cpp Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes remove the check on MemoryAddress.NULL(JDK17) MemorySegment.NULL(JDK20) for the pointer argument/return value as this type of segment/address is acceptable in the native function, depending upon how the segment/address is used. Fixes: eclipse-openj9#17400, eclipse-openj9#16761 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
added
comp:vm
project:panama
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes remove the check on MemoryAddress.NULL(JDK17)
MemorySegment.NULL(JDK20) for the pointer argument/return
value as this type of segment/address is acceptable in the
native function, depending upon how the segment/address
is used.
Fixes: #17400, #16761
Signed-off-by: ChengJin01 jincheng@ca.ibm.com