(0.40) Add checkpoint delay when clinit is occuring #17652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is PR addresses cases where a class is being initialized on a non-checkpoint thread while a checkpoint occurs. This scenario may lead to cases where a deadlock occurs when when attempting to initialize a class during a pre/post checkpoint hook. This PR address the issue by waiting for threads currently initializing a class to complete before taking a checkpoint up to 1ms. After the timeout, an exception will be thrown (unless -XX:-J9VM_CRIU_IS_THROW_ON_DELAYED_CHECKPOINT_ENABLED is specified) Also, this PR adds more detailed messages to checkpoint dir exceptions. Fixes: eclipse-openj9#15806 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Related: eclipse-openj9#15806 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
babsingh
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.