Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source build version for Valhalla to JDK22 #17760

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update source build version for Valhalla to JDK22 #17760

merged 1 commit into from
Jul 10, 2023

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Jul 10, 2023 •
edited

Update source build version for Valhalla to JDK22

@a7ehuo a7ehuo requested a review from hangshao0 July 10, 2023 14:50
@a7ehuo a7ehuo added the project:valhalla Used to track Project Valhalla related work label Jul 10, 2023
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jul 10, 2023

This PR should resolve the nightly Valhalla test build failure with openj9-openjdk-jdk.valuetypes.

22:06:02      [javac] /home/jenkins/workspace/Test_openjdkValhalla_j9_sanity.functional_x86-64_linux_valhalla_Nightly_testList_0/aqa-tests/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeArrayTests.java:45: error: value classes are not supported in -source 20
22:06:02      [javac] 	static value class PointV implements SomeIface {
22:06:02      [javac] 	       ^
22:06:02      [javac]   (use -source 21 or higher to enable value classes)
22:06:02      [javac] /home/jenkins/workspace/Test_openjdkValhalla_j9_sanity.functional_x86-64_linux_valhalla_Nightly_testList_0/aqa-tests/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeArrayTests.java:58: error: primitive classes are not supported
22:06:02      [javac] 	static primitive class PointPV implements SomeIface {

@a7ehuo a7ehuo changed the title Change source build version for Valhalla to JDK21 Update source build version for Valhalla to JDK21 Jul 10, 2023
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jul 10, 2023

@hangshao0 May I ask you to review this change? Thank you!

@hzongaro fyi

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended xlinuxval jdknext

@a7ehuo
Update source build version for Valhalla to JDK22
c2a259d 
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo changed the title Update source build version for Valhalla to JDK21 Update source build version for Valhalla to JDK22 Jul 10, 2023
@hangshao0
Copy link
Contributor

Jenkins test sanity,extended xlinuxval jdknext

hangshao0
hangshao0 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@hangshao0 hangshao0 merged commit a411eb6 into eclipse-openj9:master Jul 10, 2023
6 checks passed
@a7ehuo a7ehuo deleted the fix-valhalla-build-jdk21 branch March 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

Assignees
No one assigned
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a7ehuo @hangshao0