Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullRestricted Valhalla attribute cfdump support #18035

Merged
merged 1 commit into from Sep 5, 2023

Conversation

theresa-m
Copy link
Contributor

Related: #17340

Test Class

I compiled this using https://github.com/openjdk/valhalla/tree/lw5

class Test {
        static FieldTest! ft;
}
value class FieldTest {
        public implicit FieldTest();
}

Classfilewriter.cpp changes

$~/openj9builds/openj9-openjdk-jdk.valuetypes/build/macosx-aarch64-server-release/vm/runtime/cfdump -t Test.class
Wrote 267 bytes to output file Test.j9class
$ ~/openj9builds/openj9-openjdk-jdk.valuetypes/build/macosx-aarch64-server-release/vm/runtime/cfdump Test.j9class 
class Test extends java.lang.Object
{
    static FieldTest! ft;
    void <init>();
}

Main.c changes:

~/openj9builds/openj9-openjdk-jdk.valuetypes/build/macosx-aarch64-server-release/vm/runtime/cfdump -d Test.class

…
Fields (1):
  Name: 9 -> ft
  Signature: 10 -> LFieldTest;
  Access Flags: 0x8 ( 
  access: default static )
  Attributes (1):
    NullRestricted:
…

runtime/bcutil/ClassFileWriter.cpp Outdated Show resolved Hide resolved
runtime/bcutil/ClassFileWriter.cpp Outdated Show resolved Hide resolved
runtime/bcutil/ClassFileWriter.cpp Outdated Show resolved Hide resolved
runtime/cfdumper/main.c Outdated Show resolved Hide resolved
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@hangshao0
Copy link
Contributor

Jenkins test sanity,extended xlinuxval jdknext

@hangshao0 hangshao0 added comp:vm project:valhalla Used to track Project Valhalla related work labels Sep 1, 2023
@hangshao0 hangshao0 merged commit 8675daf into eclipse-openj9:master Sep 5, 2023
6 checks passed
@theresa-m theresa-m deleted the nr_cfdump branch September 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants