Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JVM_LoadZipLibrary() #18055

Merged
merged 2 commits into from Sep 1, 2023
Merged

Implement JVM_LoadZipLibrary() #18055

merged 2 commits into from Sep 1, 2023

Conversation

keithc-ca
Copy link
Contributor

The stub had the wrong signature: this corrects it and provides an implementation.

Fixes: #17996.

@keithc-ca
Correct return type of JVM_LoadZipLibrary()
da88423 
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Correct return type of JVM_LoadZipLibrary()
1578cc5 
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
wip

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Implement JVM_LoadZipLibrary()

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca keithc-ca requested a review from tajila August 30, 2023 20:55
@tajila
Copy link
Contributor

tajila commented Sep 1, 2023

jenkins test sanity alinux jdk21

@tajila
Copy link
Contributor

tajila commented Sep 1, 2023

jenkins test sanity win jdk8

@keithc-ca
Copy link
Contributor Author

I think you meant "alinux64" instead of "alinux". I'll let you decide whether the Windows build is sufficient or you want that build as well.

@keithc-ca keithc-ca mentioned this pull request Sep 1, 2023
Merged
@keithc-ca
Copy link
Contributor Author

If #18069 is accepted, "alinux" will be equivalent to "alinux64".

@tajila
Copy link
Contributor

tajila commented Sep 1, 2023

jenkins test sanity alinux jdk21

@keithc-ca
Copy link
Contributor Author

#18069 is not yet merged, so if you want that aarch64 Linux build, you'll have to say "alinux64" for the time being.

@keithc-ca
Copy link
Contributor Author

Jenkins test sanity alinux64 jdk21

@tajila
Copy link
Contributor

tajila commented Sep 1, 2023

Known failure

23:16:03.320 0x19200j9vmutil(j9vm).15     *   ** ASSERTION FAILED ** at /home/jenkins/workspace/Build_JDK21_aarch64_linux_Personal/openj9/runtime/util/mthutil.c:600: ((((uintptr_t)-1) != methodIndex))
JVMDUMP039I Processing dump event "traceassert", detail "" at 2023/09/01 19:16:03 - please wait.

@tajila tajila merged commit e57170e into eclipse-openj9:master Sep 1, 2023
5 of 7 checks passed
@keithc-ca keithc-ca deleted the zip branch September 5, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.exe Crashes when JPackage Bundles it
2 participants
@keithc-ca @tajila