Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store JITServer AOT methods if they are delayed #18059

Merged
merged 1 commit into from Sep 1, 2023

Conversation

cjjdespres
Copy link
Contributor

If the option -XX:+JITServerAOTCacheDelayMethodRelocation is in effect, then we delay the relocation of received AOT methods by default. When this is the case, we should also store these methods in the local SCC so that they will be available to be relocated later.

If the option -XX:+JITServerAOTCacheDelayMethodRelocation is in effect,
then we delay the relocation of received AOT methods by default. When
this is the case, we should also store these methods in the local SCC so
that they will be available to be relocated later.

Signed-off-by: Christian Despres <despresc@ibm.com>
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu. Prompted by Alexey's comment #17945 (comment). If we really wanted to avoid storing methods locally, we might consider ignoring that particular option (and not delaying methods) if we're using our temporary layer.

It might also be better to have the check for method storage be on canRelocateMethod, since if that's false then the rest of the code assumes that the method will be stored in the local SCC for later loading.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Aug 31, 2023

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17

@mpirvu mpirvu self-assigned this Aug 31, 2023
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Aug 31, 2023
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Aug 31, 2023
@mpirvu mpirvu merged commit 2b34667 into eclipse-openj9:master Sep 1, 2023
11 checks passed
JIT as a Service automation moved this from In progress to Done Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants