Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_build_extra_options() API for wrapper job #18062

Merged
merged 1 commit into from Sep 11, 2023
Merged

Fix set_build_extra_options() API for wrapper job #18062

merged 1 commit into from Sep 11, 2023

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Aug 31, 2023 •
edited

Console log Extra options specified as build parameters
Change behaviour to append extra options after spec options

@fengxue-IS
Copy link
Contributor Author

fengxue-IS commented Aug 31, 2023 •
edited

PersonalBuild passed

@fengxue-IS fengxue-IS marked this pull request as ready for review August 31, 2023 21:53
@AdamBrousseau
Copy link
Contributor

jenkins compile amac jdk11

@AdamBrousseau
Copy link
Contributor

infra issue 4740

AdamBrousseau
AdamBrousseau reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to verify, but I think this breaks the z/os build which passes EXTRA_GETSOURCE_OPTIONS_JDK11_s390x_zos from a wrapper pipeline to PBTAll.
Can you have a look at that build and test your change there please?
Pipeline-Build-Test-Personal-s390x_zos

@fengxue-IS
Copy link
Contributor Author

I'll test the zos build using private repo and update this PR once that issue have been resolved.

@fengxue-IS
Copy link
Contributor Author

So the issue with Pipeline-Build-Test-Personal-s390x_zos is due to conflicting use of EXTRA_GETSOURCE_OPTIONS between the buildenv/jenkins/jobs/pipelines/Pipeline-Build-Test-All.groovy and buildenv/jenkins/java_next/Pipeline-Build-Test-All-Java.groovy from tooling

The conflict seem to only affect get source parameters, so I will modify the change to only append user specified configure parameters to the build pipeline in the last stage.

@fengxue-IS
Fix set_build_extra_options() API for wrapper job
e3da498 
Console log Extra options specified as build parameters
Change behaviour to append extra options after spec options

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS
Copy link
Contributor Author

updated changes per previous comment,
Personal builds in progress:
zos
Personal

@AdamBrousseau
Copy link
Contributor

jenkins compile amac jdk11

AdamBrousseau
AdamBrousseau approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing.

@AdamBrousseau AdamBrousseau merged commit 03d1dbd into eclipse-openj9:master Sep 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBrousseau AdamBrousseau AdamBrousseau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fengxue-IS @AdamBrousseau