Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decReferenceCount out of else block #18075

Merged
merged 1 commit into from Sep 12, 2023

Conversation

dylanjtuttle
Copy link
Contributor

Move a call to decReferenceCount out of an else block because a case existed where the indexChild of the BNDCHKwithSpineCHKEvaluator node wasn't having its reference count decremented

Closes: #15436

Move a call to decReferenceCount out of an else block
because cases existed where the indexChild of the
BNDCHKwithSpineCHKEvaluator node wasn't having
its reference count decremented

Closes: eclipse-openj9#15436
Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro hzongaro self-assigned this Sep 11, 2023
@hzongaro
Copy link
Member

Jenkins test sanity.functional all jdk11,jdk17,jdk21

@hzongaro
Copy link
Member

MacOS failure for JDK17 appears to be issue #18076

@hzongaro
Copy link
Member

JDK 11 PPC64LE Linux testing was aborted for some reason. Rerunning:

Jenkins test sanity.functional ppc64le_linux jdk11

@hzongaro
Copy link
Member

One known failure in testing — remainder of testing was clean. Merging.

@hzongaro hzongaro merged commit 080b859 into eclipse-openj9:master Sep 12, 2023
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure at omr/compiler/codegen/CodeGenRA.cpp:106: !regsAreLive when PROD_WITH_ASSUMES is enabled
2 participants