Don't invoke shutdown signal handler until JVM init completes #18085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
commented
Sep 6, 2023
| if (J9_ARE_ANY_BITS_SET(vm->runtimeFlags, J9_RUNTIME_EXIT_STARTED)) { | ||
| shutdownStarted = TRUE; | ||
| /* Don't invoke handler if JVM hasn't initialized or JVM exit has started. */ | ||
| issueReadBarrier(); |
There was a problem hiding this comment.
Signal handlers should not incorporate lock operations since they are not signal-safe. I have replaced the lock with a read barrier to read the most up-to-date vm->runtimeFlags value.
|
Running a personal build to check if there are any side-effects. I will move the PR out of the draft state once the personal build looks good. @gacholio Requesting your review. @pshipton @tajila fyi, this is related to internal issue 148771. |
|
The personal build looks good; no side-effects seen. This PR is ready to be reviewed. |
gacholio
approved these changes
Sep 7, 2023
|
jenkins test sanity zlinux jdk21 |
|
jenkins compile win jdk8 |
JVM init path: J9_CreateJavaVM. JVM exit paths: protectedDestroyJavaVM and exitJavaVM. A segfault or other side-effects can happen if the JVM init and exit paths execute concurrently. The exit path can be taken if a shutdown signal is raised and the shutdown handler is invoked. JVM shutdown signals are SIGINT, SIGTERM and SIGHUP. Preventing invocation of the exit path from the shutdown signal handler until the JVM initialization completes resolves the above side-effects. Related: - eclipse-openj9#17101 - eclipse-openj9#17438 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_scopedvaluecache
branch
2 times, most recently
from
6d73779
to
d4dfa6c
Compare
|
Accidentally pushed into this PR. The impact of the accidental push has been reverted. Old PR builds:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVM init path:
J9_CreateJavaVM.JVM exit paths:
protectedDestroyJavaVMandexitJavaVM.A segfault or other side-effects can happen if the JVM init and
exit paths execute concurrently.
The exit path can be taken if a shutdown signal is raised and the
shutdown handler is invoked. JVM shutdown signals are
SIGINT,SIGTERMand
SIGHUP.Preventing invocation of the exit path from the shutdown signal handler
until the JVM initialization completes resolves the above side-effects.
Related: