Ignore -Xgc:enableArrayletDoubleMapping silently #18109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arraylet Double Mapping feature is not supported for all platforms. Current behaviour is return "unsupported option error". This prevents to use the same Java command line across platforms. New behaviour is to ignore -Xgc:enableArrayletDoubleMapping and -Xgc:disbleArrayletDoubleMapping silently on platforms where this feature is not supported. Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
|
Ideally we should let isArrayletDoubleMapRequested be changed by cmdline option but leaving isArrayletDoubleMapAvailable false for unsupported platfroms, since from VGC it would be clear if it was supported or not (we report both of these flags there). But since it would be a larger scope of changes, and this feature is anyway to be deprecated eventually, I'm ok with this quick fix. |
amicic
approved these changes
Sep 11, 2023
|
jenkins compile win jdk8 |
|
jenkins compile aix jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arraylet Double Mapping feature is not supported for all platforms. Current behaviour is return "unsupported option error". This prevents to use the same Java command line across platforms.
New behaviour is to ignore -Xgc:enableArrayletDoubleMapping and -Xgc:disbleArrayletDoubleMapping silently on platforms where this feature is not supported.