StackWalker updates for Java 22 #18145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add StackWalker.Option.DROP_METHOD_INFO * add stub for JVM_ExpandStackFrameInfo() * update signatures of JVM_CallStackWalk() and JVM_MoreStackWalk() Various general improvements to StackWalker: * make all fields final * don't retain Set<Option> (all needed information is in flags) * add newInstanceWithMonitors() for use by PinnedThreadPrinter Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
This doesn't implement DROP_METHOD_INFO, do we need a new issue to track adding this support? |
|
jenkins test sanity,sanity.openjdk win jdk21,jdknext |
I expected that the option was just a performance hint (to avoid gathering information the client doesn't need), but there are tests that assert |
pshipton
approved these changes
Sep 15, 2023
keithc-ca
added a commit
to keithc-ca/openj9
that referenced
this pull request
Oct 27, 2023
This should have been included in eclipse-openj9#18145. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackWalker.Option.DROP_METHOD_INFOJVM_ExpandStackFrameInfo()JVM_CallStackWalk()andJVM_MoreStackWalk()Various general improvements to
StackWalker:finalSet<Option>(all needed information is inflags)newInstanceWithMonitors()for use byPinnedThreadPrinterFixes #18100.