Collect debuginfo files to help diagnose omr_ddrgen failures with gcc11 #18194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Sep 25, 2023
buildenv/jenkins/common/build.groovy
Outdated
| @@ -531,6 +531,9 @@ def archive_diagnostics(javaVersionJdkImageDir = null) { | |||
| if (SPEC.contains('win')) { | |||
| // collect *.pdb files to help diagnose omr_ddrgen failures | |||
| findCrashDataCmd += " -o -name '*.pdb'" | |||
| } else if (SPEC.contains('gcc11')) { | |||
There was a problem hiding this comment.
Shouldn't we collect .debuginfo for all linux specs rather than the special and temporary aarch64_linux_gcc11 spec?
There was a problem hiding this comment.
Updated to apply for all linux specs.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
pshipton
reviewed
Sep 25, 2023
| if (SPEC.contains('win')) { | ||
| if (SPEC.contains('linux')) { | ||
| // collect *.debuginfo files to help diagnose omr_ddrgen failures | ||
| findCrashDataCmd += " -o -name '*.debuginfo'" |
There was a problem hiding this comment.
Are you going to need anything else like .so files?
There was a problem hiding this comment.
No, omr_ddrgen only reads .debuginfo files (on Linux).
pshipton
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None were collected in https://openj9-jenkins.osuosl.org/job/Build_JDK21_aarch64_linux_gcc11_Personal/1; this should fix that.