Add support for thread local allocation stats #18202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
force-pushed
the
issue3
branch
3 times, most recently
from
8cddc42
to
7d91123
Compare
tajila
force-pushed
the
issue3
branch
7 times, most recently
from
ad804dd
to
3245fea
Compare
Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
gacholio
approved these changes
Oct 26, 2023
|
No description provided. |
|
jenkins test sanity zlinux jdk21 |
|
jenkins compile win jdk8 |
keithc-ca
reviewed
Oct 26, 2023
| if (mmfns->j9gc_get_cumulative_bytes_allocated_by_thread(currentThread, &allocatedBytes)) { | ||
| result = (jlong) allocatedBytes; | ||
| } | ||
| goto done; |
There was a problem hiding this comment.
This leads to a second call to internalExitVMToJNI(); perhaps the done label should be after that second call?
There was a problem hiding this comment.
Or remove the exit call above - the GC code is called with VM access below, so it must not care.
There was a problem hiding this comment.
I think removing the call above would be more consistent (then both places where `j9gc_get_cumulative_bytes_allocated_by_thread() are called would be in the VM).
|
@TobiAjila the new feature should be documented in the What's New. Please create a docs issue https://github.com/eclipse-openj9/openj9-docs/issues/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.