Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for sizing the IProfiler hash tables #18241

Merged
merged 1 commit into from Oct 6, 2023

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Oct 5, 2023

Two new -Xjit options are introduced which can be used to control the number of buckets in the two hash tables used by IProfiler:

-Xjit:iprofilerBcHashTableSize=
-Xjit:iprofilerMethodHashTableSize=

Note that these hash tables are not dynamically resizeable. This commit does not change the default values for these two hash tables.

Two new -Xjit options are introduced which can be used to control
the number of buckets in the two hash tables used by IProfiler:

-Xjit:iprofilerBcHashTableSize=
-Xjit:iprofilerMethodHashTableSize=

Note that these hash tables are not dynamically resizeable.
This commit does not change the default values for these two hash
tables.

Signed-off-by: Marius <mpirvu@ca.ibm.com>
@mpirvu mpirvu added the comp:jit label Oct 5, 2023
@mpirvu
Copy link
Contributor Author

mpirvu commented Oct 5, 2023

@dsouzai Could you please review/merge this PR? Thanks

@dsouzai dsouzai self-assigned this Oct 6, 2023
@dsouzai
Copy link
Contributor

dsouzai commented Oct 6, 2023

jenkins test sanity xlinux,plinux,zlinux jdk21

@dsouzai
Copy link
Contributor

dsouzai commented Oct 6, 2023

zlinux failure

[2023-10-06T15:26:56.597Z] Output from test:
[2023-10-06T15:26:56.597Z]  [OUT] start running script
[2023-10-06T15:26:56.597Z]  [OUT] vlog sslVlog1 does not exist
[2023-10-06T15:26:56.597Z]  [OUT] 
[2023-10-06T15:26:56.597Z]  [OUT] Outputting previous test output
[2023-10-06T15:26:56.597Z]  [OUT] Pre-checkpoint
[2023-10-06T15:26:56.597Z]  [OUT] Performing CRIUSupport.checkpointJVM(), current thread name: main, Fri Oct 06 11:26:51 EDT 2023, System.currentTimeMillis(): 1696606011799, System.nanoTime(): 1696606011794645978
[2023-10-06T15:26:56.597Z]  [OUT] Error (criu/cr-restore.c:1649): Pid 19347 do not match expected 19346
[2023-10-06T15:26:56.597Z]  [OUT] Error (criu/cr-restore.c:2293): Restoring FAILED.
[2023-10-06T15:26:56.597Z]  [OUT] Error (criu/cr-restore.c:1414): 19347 exited, status=1
[2023-10-06T15:26:56.597Z]  [OUT] 
[2023-10-06T15:26:56.597Z]  [OUT] CAT VLOG FORCE PASS
[2023-10-06T15:26:56.597Z]  [OUT] Removed test output files
[2023-10-06T15:26:56.597Z]  [OUT] finished script
[2023-10-06T15:26:56.597Z] >> Success condition was not found: [Output match: CHECKPOINT RESTORE: Ready for restore]
[2023-10-06T15:26:56.598Z] >> Success condition was not found: [Output match: SSL connection on socket]
[2023-10-06T15:26:56.598Z] >> Required condition was not found: [Output match: Connected to a server]
[2023-10-06T15:26:56.598Z] >> Success condition was found: [Output match: CAT VLOG FORCE PASS]

will be fixed by #18225

@dsouzai dsouzai merged commit 2d48e93 into eclipse-openj9:master Oct 6, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants