Implement Thread.findScopedValueBindings() #18255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
findScopedValueBindings_v2
branch
2 times, most recently
from
6e0ff43
to
41966a0
Compare
gacholio
approved these changes
Oct 16, 2023
|
jenkins test sanity zlinux jdk21 |
|
jenkins compile win jdk8,jdk21 |
|
PR build links:
@gacholio I will squash the commits. The above PR builds should be valid after the squash. |
babsingh
force-pushed
the
findScopedValueBindings_v2
branch
from
41966a0
to
18ea55d
Compare
Walk the stack frames to look for the runWith() method and get its first argument, which should be an instance of java.lang.ScopedValue$Snapshot. Closes: eclipse-openj9#16677 Closes: eclipse-openj9#17402 Co-authored-by: Gengchen Tuo gengchen.tuo@ibm.com Signed-off-by: Babneet Singh sbabneet@ca.ibm.com
babsingh
force-pushed
the
findScopedValueBindings_v2
branch
from
18ea55d
to
e57519e
Compare
|
@gacholio Both PR build jobs have passed. |
keithc-ca
reviewed
Oct 16, 2023
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Oct 17, 2023
Addresses the post-merge feedback from eclipse-openj9#18255. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
midronij
pushed a commit
to midronij/openj9
that referenced
this pull request
Oct 26, 2023
Addresses the post-merge feedback from eclipse-openj9#18255. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walk the stack frames to look for the
runWith()method and getits first argument, which should be an instance of
java.lang.ScopedValue$Snapshot.Closes: #16677
Closes: #17402
Co-authored-by: Gengchen Tuo gengchen.tuo@ibm.com
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com