Remove misleading comment #18284
Merged
Remove misleading comment #18284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A compile should be sufficient for these changes. jenkins compile plinux jdk8,jdk21 PR build: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4560 |
|
Code changes LGTM. The below details are missing in the commit message. Can you please update the commit message? |
This class is also used for Java 8, so the comment that says "@SInCE Java 11" is misleading. Also, organize imports, tidy up whitespace. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Commit message updated. For the record, the requested build is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4560/. |
babsingh
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4560: the build jobs have passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is also used for Java 8, so the comment that says
@since Java 11is misleading.Also, organize imports, tidy up whitespace.