Renamed warm strategy opts #18289
Merged
Renamed warm strategy opts #18289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default optimization strategy for the warm optimization level is `cheapWarmStrategyOpts`, while the older, `warmStrategyOpts` is not used (unless a specific option is given). This commit renames warmStrategyOpts to oldWarmStrategyOpts and cheapWarmStrategyOpts to warmStrategyOpts Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
@vijaysun-omr Could you please review this PR? Thank you |
vijaysun-omr
approved these changes
Oct 16, 2023
|
Jenkins test sanity all jdk11 |
|
Tests on mac failed due to infra: On Power there were CRIU failures, but not caused by this PR. |
|
Checks have passed except for the known issues mentioned. This is a cosmetic change anyway to make it easier to read the code and reason about the warm strategy in use. Merging. |
| { | ||
| return j9CompilationStrategies[strategy]; | ||
| } | ||
| return j9CompilationStrategies[strategy]; |
There was a problem hiding this comment.
Is there a cleanup task (separate PR) to free up the option bit for TR_DisableCheapWarmOpts ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default optimization strategy for the warm optimization level is
cheapWarmStrategyOpts, while the older,warmStrategyOptsis not used (unless a specific option is given). This commit renameswarmStrategyOpts to oldWarmStrategyOpts
and
cheapWarmStrategyOpts to warmStrategyOpts