Use defining symrefs from defining map for <eaEscapeHelper> call #18315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TR_EscapeAnalysisTools::processSymbolReferences uses a BitVector to accumulate the symbol reference numbers for symbols that are to be loaded on an <eaEscapeHelper> call. In walking through the set of defining symbols associated with a particular local symbol, the code was adding the reference number for the original symbol to the BitVector of symbols to be loaded for the <eaEscapeHelper> call rather than the reference numbers for the associated defining symbols. That can lead Escape Analysis to miss potential escapes of references through induce OSR blocks or peeked calls.
|
Vijay @vijaysun-omr, may I ask you to review this change? |
This was referenced Oct 21, 2023
vijaysun-omr
approved these changes
Oct 25, 2023
|
jenkins test sanity zlinuxjit jdk17 |
|
This is fixing what is clearly a typo, wrong logic. I have reviewed and the fix looks right to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR_EscapeAnalysisTools::processSymbolReferencesuses aBitVectorto accumulate the symbol reference numbers for symbols that are to be loaded on an<eaEscapeHelper>call. In walking through the set of defining symbols associated with a particular local symbol, the code was adding the reference number for the original symbol to theBitVectorof symbols to be loaded for the<eaEscapeHelper>call rather than the reference numbers for the associated defining symbols. That can lead Escape Analysis to miss potential escapes of references through induce OSR blocks or peeked calls.This fixes a problem that was introduced in commit eddbd1b, at line 156 of EscapeAnalysisTools.cpp.
Fixes #18246