Use -fno-omit-frame-pointer on x86_64-mac JIT builds #18346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keith @keithc-ca, Daryl @0xdaryl, may I ask you to review? |
keithc-ca
requested changes
Oct 25, 2023
0xdaryl
approved these changes
Oct 26, 2023
A bug in libunwind on x86_64-macOS results in intermittent crashes from libunwind if a C++ exception is thrown from OMR::Compilation::failCompilation. In order to work around the problem, the JIT compiler needs to be compiled with -fno-omit-frame-pointer on that combination of CPU and operating system. That option will be used only on JDK 22 or later builds for now, while the impact on compile-time and start-up performance is evaluated.
hzongaro
force-pushed
the
no-omit-frame-pointer-experiment
branch
from
3ff6af8
to
30dc783
Compare
|
Thanks, Keith! It's ready for a re-review. |
|
Jenkins compile osx jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging |
|
Jenkins compile alinux,osx jdk21 |
|
The osx build failed I think that's an infrastructure issue: restarting. |
keithc-ca
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in libunwind on x86_64-macOS results in intermittent crashes from libunwind if a C++ exception is thrown from
OMR::Compilation::failCompilation. In order to work around the problem, the JIT compiler needs to be compiled with-fno-omit-frame-pointeron that combination of CPU and operating system.That option will be used only on JDK 22 or later builds for now, while the impact on compile-time and start-up performance is evaluated.
Fixes #18321