Adapt cross package interface test to correctly handle Java 8 #18398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
requested changes
Nov 6, 2023
test/functional/Jsr292/src/com/ibm/j9/jsr292/LookupAPITests_Find.java
Outdated
Show resolved
Hide resolved
test/functional/Jsr292/src/com/ibm/j9/jsr292/LookupAPITests_Find.java
Outdated
Show resolved
Hide resolved
test/functional/Jsr292/src/com/ibm/j9/jsr292/LookupAPITests_Find.java
Outdated
Show resolved
Hide resolved
|
In the commit message:
|
Simply a commit message template error. Good catch. |
This patch fixes eclipse-openj9#14987. OJDK MHs use OJDK's version of findSpecial. Before JEP 274, which was implemented for Java 9, findSpecial did not support interface method access. This patch handles the IllegalAccessException that is thrown for OpenJ9 with OJDK MHs enabled. Closes: eclipse-openj9#14987 Signed-off-by: Nathan Henderson <nathan.henderson@ibm.com>
ThanHenderson
changed the title
|
jenkins test extended.functional zlinuxojdk292 jdk8,jdk11 |
|
jenkins test extended.functional plinux jdk8,jdk11 |
babsingh
approved these changes
Nov 7, 2023
babsingh
reviewed
Nov 7, 2023
ThanHenderson
added
jdk8
comp:vm
project:MH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #14987. OJDK MHs use OJDK's version of
findSpecial. Before JEP 274, which was implemented for Java 9,findSpecialdid not support interface method access. This patch handles theIllegalAccessExceptionthat is thrown for OpenJ9 with OJDK MHs enabled.Closes: #14987
Signed-off-by: Nathan Henderson nathan.henderson@ibm.com