Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to spec for BootstrapMethodError for OJDK MHs for JDK 8 #18445

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conform to spec for BootstrapMethodError for OJDK MHs for JDK 8 #18445

merged 1 commit into from Nov 14, 2023

Conversation

ThanHenderson
Copy link
Contributor

This patch fixes both #14986 and #14991. The implementation of OJDK MHs for JDK 8 did not conform to the spec with respect to wrapping resolution errors relating to bootstrap methods in a BootstrapMethodError.

Issues: #14986 #14991
Signed-off-by: Nathan Henderson nathan.henderson@ibm.com

@ThanHenderson
Conform to spec for BootstrapMethodError for OJDK MHs for JDK 8
60f121a 
This patch fixes both eclipse-openj9#14986 and
eclipse-openj9#14991. The implementation of OJDK MHs for JDK 8
did not conform to the spec with respect to wrapping resolution errors
relating to bootstrap methods in a BootstrapMethodError.

Issues: eclipse-openj9#14986 eclipse-openj9#14991
Signed-off-by: Nathan Henderson <nathan.henderson@ibm.com>
@babsingh
Copy link
Contributor

jenkins test sanity.functional,extended.functional,sanity.openjdk,extended.openjdk zlinuxojdk292 jdk8,jdk11

@babsingh
Copy link
Contributor

jenkins test sanity.functional,extended.functional,sanity.openjdk,extended.openjdk plinux jdk8,jdk11,jdk17

@babsingh
Copy link
Contributor

Only network issues and known failures are seen:

@babsingh babsingh merged commit f819b7e into eclipse-openj9:master Nov 14, 2023
17 of 28 checks passed
This was referenced Nov 14, 2023
Closed
Closed
@ThanHenderson ThanHenderson added jdk8 comp:vm project:MH Used to track Method Handles related work labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
comp:vm jdk8 project:MH Used to track Method Handles related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThanHenderson @babsingh