Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly link omrsig and enable OMRPORT_OMRSIG_SUPPORT globally #2631

Merged
merged 5 commits into from
Sep 14, 2018
Merged

Properly link omrsig and enable OMRPORT_OMRSIG_SUPPORT globally #2631

merged 5 commits into from
Sep 14, 2018

Commits on Sep 13, 2018

  1. Properly link omrsig when building constgen and j9ddrgen 

    When building constgen and j9ddrgen, omrsig should be linked when
J9VM_PORT_OMRSIG_SUPPORT is enabled.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
    @babsingh
    babsingh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    cfe191c View commit details
    Browse the repository at this point in the history

  2. Remove OMRPORT_OMRSIG_SUPPORT definitions 

    Currently, OMRPORT_OMRSIG_SUPPORT is only defined while building the
port library. But, OMRPORT_OMRSIG_SUPPORT should be defined globally.
This will allow omrsig macros such as OMRSIG_SIGNAL and OMRSIG_SIGACTION
to be used consistently across OpenJ9.

Removing localized definitions of OMRPORT_OMRSIG_SUPPORT before enabling
it globally. This will prevent redundant definitions of
OMRPORT_OMRSIG_SUPPORT when it is enabled globally.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
    @babsingh
    babsingh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    11c7267 View commit details
    Browse the repository at this point in the history

  3. Enable OMRPORT_OMRSIG_SUPPORT globally in OpenJ9 

    Currently, OMRPORT_OMRSIG_SUPPORT is only defined while building the
port library. But, OMRPORT_OMRSIG_SUPPORT should be defined globally.
This will allow omrsig macros such as OMRSIG_SIGNAL and OMRSIG_SIGACTION
to be used consistently across OpenJ9. Thus, OMRPORT_OMRSIG_SUPPORT is
enabled globally.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
    @babsingh
    babsingh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    45135e8 View commit details
    Browse the repository at this point in the history

  4. Fix indentation in hyvm/module.xml 

    Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
    @babsingh
    babsingh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    2311b33 View commit details
    Browse the repository at this point in the history

  5. Link omrsig to port and vm only if J9VM_PORT_OMRSIG_SUPPORT is enabled 

    Currently, omrsig is linked to port and vm unconditionally. omrsig
should be linked to port and vm only if J9VM_PORT_OMRSIG_SUPPORT is
enabled.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
    @babsingh
    babsingh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    31f655c View commit details
    Browse the repository at this point in the history