Enable DDR tests for AIX #2939
Merged
Enable DDR tests for AIX #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikezhang1234567890
force-pushed
the
aix-ddr-test
branch
from
42fc757
to
91ae76a
Compare
pshipton
reviewed
Sep 19, 2018
| @@ -30,7 +30,7 @@ | |||
| </variations> | |||
| <command>$(MKTREE) $(REPORTDIR); \ | |||
| cd $(REPORTDIR); \ | |||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl zos ; \ | |||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl all zos ; \ | |||
There was a problem hiding this comment.
"all zos" is inconsistent with the later calls which specify "all"
There was a problem hiding this comment.
all is passed in to the sysvcleanup.pl script to ensure data from all users is cleaned up. AIX and ZOS have different values for user info when the test target is AIX/ZOS. sysvcleanup.pl accepts both aix and zos as a second option but they are identical.
pshipton
reviewed
Sep 19, 2018
| <variations> | ||
| <variation>NoOptions</variation> | ||
| </variations> | ||
| <command>$(MKTREE) $(REPORTDIR); \ | ||
| cd $(REPORTDIR); \ | ||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl zos ; \ | ||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl all zos ; \ |
| <variations> | ||
| <variation>NoOptions</variation> | ||
| </variations> | ||
| <command>$(MKTREE) $(REPORTDIR); \ | ||
| cd $(REPORTDIR); \ | ||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl zos ; \ | ||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl all zos ; \ |
| <command>$(MKTREE) $(REPORTDIR); \ | ||
| cd $(REPORTDIR); \ | ||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl all zos ; \ |
|
|
||
| <test> |
There was a problem hiding this comment.
why is a specific test required for aix?
There was a problem hiding this comment.
sysvcleanup.pl sets different values for user info for AIX and ZOS.
| @@ -91,15 +91,14 @@ | |||
| </variations> | |||
| <command>$(MKTREE) $(REPORTDIR); \ | |||
| cd $(REPORTDIR); \ | |||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl zos ; \ | |||
| perl $(JVM_TEST_ROOT)$(D)TestConfig$(D)scripts$(D)tools$(D)sysvcleanup.pl all ; \ | |||
| $(JAVA_COMMAND) $(JVM_OPTIONS) -Xint \ | |||
There was a problem hiding this comment.
You can remove the -Xint from all these tests. It's there for historical reasons when the jit was less reliable, but its no longer required. The tests will run faster.
Add LD_LIBRARY_PATH and LIBPATH env variables when running ddrgen due to its new dependency on libomrsig. On AIX, the search path is not saved in the executable when it is created since we do not have a direct equivalent to setting rpath=$ORIGIN as a compiler flag. Signed-off-by: mikezhang <mike.h.zhang@ibm.com>
|
@mikezhang1234567890 I expect you've already noticed, but please fix the conflicts. |
- enable callsitedbgddrext, classesdbgddrext, shrcdbgddrext, and modularityddrtests cmdlinetests for AIX - enable DDR_Test for AIX - create new AIX and zOS targets in playlist.xml for the DDR cmdline tests and use correct arguments to sysvcleanup.pl script. Pass in zos option since zos and aix options are identical in sysvcleanup.pl - limit heap size in DDR tests to 256MB, since on AIX the core file scales with heap size, which can hit filesystem limits Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
mikezhang1234567890
force-pushed
the
aix-ddr-test
branch
from
91ae76a
to
dd2abe4
Compare
mikezhang1234567890
changed the title
|
@keithc-ca or @pshipton can you review this please? |
This was referenced Oct 5, 2018
pshipton
approved these changes
Oct 5, 2018
|
Reverting as per #3248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables tests for DDR on AIX, closes #1769
modularityddrtests cmdlinetests for AIX
tests and use correct arguments to sysvcleanup.pl script. Pass in zos
option since zos and aix options are identical in sysvcleanup.pl
scales with heap size, which can hit filesystem limits
Signed-off-by: Mike Zhang mike.h.zhang@ibm.com
This PR depends on the following extensions repo PRs, since the DDR tests do not compile without DDR enabled on AIX:
ibmruntimes/openj9-openjdk-jdk8#116
ibmruntimes/openj9-openjdk-jdk9#178
ibmruntimes/openj9-openjdk-jdk10#59
ibmruntimes/openj9-openjdk-jdk11#23
ibmruntimes/openj9-openjdk-jdk#35
Doc issue is eclipse-openj9/openj9-docs#92