Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the path to libjava to include "../" #3176

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

DanHeidinga
Copy link
Member

@DanHeidinga DanHeidinga commented Oct 8, 2018

Mac OSX build requires this to initialize correctly when building JDK11.
The directory layout for a JDK11 build is jdk/lib/[compressedrefs|default].
Since the library doing the lookup is in the compressedrefs or default
directory, using ../java to lookup libjava is the correct path.

issue: #36

Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com

@DanHeidinga
Copy link
Member Author

Jenkins test sanity plinux,xlinux jdk8

@pshipton
Copy link
Member

pshipton commented Oct 9, 2018

jenkins test sanity zlinux,win jdk11

@pshipton
Copy link
Member

pshipton commented Oct 9, 2018

jenkins test sanity aix jdk11

@pshipton
Copy link
Member

pshipton commented Oct 9, 2018

@DanHeidinga fyi the failures

@DanHeidinga
Copy link
Member Author

Thanks. Looking

@DanHeidinga DanHeidinga changed the title Use J9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executable WIP: Use J9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executable Oct 9, 2018
Mac OSX build requires this to initialize correctly when building JDK11.
The directory layout for a JDK11 build is jdk/lib/[compressedrefs|default].
Since the library doing the lookup is in the compressedrefs or default
directory, using ../java to lookup libjava is the correct path.

issue: eclipse-openj9#36

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@DanHeidinga
Copy link
Member Author

jenkins test sanity zlinux,win,aix,xlinux jdk11

@DanHeidinga DanHeidinga changed the title WIP: Use J9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executable WIP: Modify the path to libjava to include "../" Oct 10, 2018
@DanHeidinga
Copy link
Member Author

@pshipton @gacholio Can one of you review this please?

@gacholio
Copy link
Contributor

WIP needs to be removed before merge.

@pshipton pshipton changed the title WIP: Modify the path to libjava to include "../" Modify the path to libjava to include "../" Oct 10, 2018
@pshipton
Copy link
Member

I believe the travis failure is caused by #3204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants