Add flag to windows specs to enable rebase #380
Conversation
|
@keithc-ca please review, thank you! |
buildspecs/j9.flags
Outdated
| @@ -2316,4 +2316,8 @@ Pass J9PORT_SIG_OPTIONS_ZOS_USE_CEEHDLR into j9sig_set_options() before the fir | |||
| <description>Compile tracegenc and run it to generate tracefiles</description> | |||
| <ifRemoved>Run java version of tracegenc</ifRemoved> | |||
| </flag> | |||
| <flag id="windows_rebase"> | |||
There was a problem hiding this comment.
This flag should be either an uma_ or build_ flag.
There was a problem hiding this comment.
I renamed the flag uma_windows_rebase.
There was a problem hiding this comment.
The format in the file is prefix_camelCaseFlag. Can you call this uma_windowsRebase to match the existing convention?
vsebe
force-pushed
the
openj9.win_rebase
branch
2 times, most recently
from
85fcc93
to
d5e4463
Compare
|
@DanHeidinga I renamed the flag to uma_windows_rebase. |
|
@vsebe Did you see my comment about the format of options in the file? They need to be formatted like |
Update UMA to generate the rebase targets when the flag is enabled. Enable the flag in the specs to run rebase IBM sdk only. Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
vsebe
force-pushed
the
openj9.win_rebase
branch
from
d5e4463
to
b5431c8
Compare
|
@DanHeidinga Renamed as recommended: uma_windowsRebase |
|
I was going to ask how this worked as it adds the flag everywhere and removes the check for So this change plus the sed script is sufficient to turn rebase off. |
|
Jenkins test sanity plinux Only running one platform as its sufficient to see that the code compiles. Windows isn't enabled in the builds yet. |
Update UMA to generate the rebase targets when the flag is enabled.
Enable the flag in the specs to run rebase IBM sdk only.
Issues: #55
Signed-off-by: Violeta Sebe vsebe@ca.ibm.com