Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set job variables for PR builds based on PR case not build case #4017

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Set job variables for PR builds based on PR case not build case #4017

merged 1 commit into from
Jan 19, 2019

Conversation

AdamBrousseau
Copy link
Contributor

@AdamBrousseau AdamBrousseau commented Dec 12, 2018 •
edited

  • Remove support for test cases since we no longer
    use our test pipelines (Switch to using Adopt JenkinsFiles for Test #1450)
  • Set job variables for PullRequest builds based on PR case
    not build case. This avoids setting job properties for PR builds
    which removes the GH trigger configuration
  • Remove test node labels as these are no longer in use

[skip ci]

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

@AdamBrousseau
Copy link
Contributor Author

jenkins compile xlinux jdk11

@AdamBrousseau
Copy link
Contributor Author

jenkins test sanity xlinux jdk11

@AdamBrousseau
Copy link
Contributor Author

PR jobs no longer overwrite Jenkins job properties
Before:

00:00:41.667 Using variables file: buildenv/jenkins/variables/defaults.yml
[Pipeline] readYaml
[Pipeline] echo
00:00:44.309 Configure Jenkins job PROPERTIES
[Pipeline] echo
00:00:44.310 Configure Build Discarder...
[Pipeline] echo
00:00:44.320 NUM_BUILDS:'20
[Pipeline] echo
00:00:44.321 NUM_ARTIFACTS:'10
[Pipeline] echo
00:00:44.322 SDK_VERSION:'11'
[Pipeline] echo
00:00:44.324 PLATFORM:'linux_x86-64_cmprssptrs'
[Pipeline] properties
[Pipeline] echo
00:00:44.433 Using OPENJDK_REPO = https://github.com/ibmruntimes/openj9-openjdk-jdk11.git OPENJDK_BRANCH = openj9 OPENJDK_SHA =

After:

00:01:52.424 Using variables file: buildenv/jenkins/variables/defaults.yml
[Pipeline] readYaml
[Pipeline] echo
00:01:53.452 Using OPENJDK_REPO = https://github.com/ibmruntimes/openj9-openjdk-jdk11.git OPENJDK_BRANCH = openj9 OPENJDK_SHA =

Test on a Build* job:
https://ci.eclipse.org/openj9/view/Sandbox/job/Adam_Build-JDK8-linux_390-64_cmprssptrs/126

00:00:18.064 Using variables file: buildenv/jenkins/variables/defaults.yml
[Pipeline] readYaml
[Pipeline] echo
00:00:18.301 Configure Jenkins job PROPERTIES
[Pipeline] echo
00:00:18.302 Configure Build Discarder...
[Pipeline] echo
00:00:18.309 NUM_BUILDS:'20
[Pipeline] echo
00:00:18.311 NUM_ARTIFACTS:'10
[Pipeline] echo
00:00:18.313 SDK_VERSION:'8'
[Pipeline] echo
00:00:18.315 PLATFORM:'linux_390-64_cmprssptrs'
[Pipeline] properties
[Pipeline] echo
00:00:19.826 WARNING: Can't determine appropriate BUILD_DENTIFIER automatically. Please add it as a build parameter if you would like it set.
[Pipeline] echo
00:00:19.839 Using OPENJDK_REPO = https://github.com/ibmruntimes/openj9-openjdk-jdk8.git OPENJDK_BRANCH = openj9 OPENJDK_SHA =

@AdamBrousseau AdamBrousseau changed the title WIP: Set job variables for PR builds based on PR case not build case Set job variables for PR builds based on PR case not build case Dec 12, 2018
@AdamBrousseau
Copy link
Contributor Author

@vsebe for review

@AdamBrousseau
Copy link
Contributor Author

jenkins test sanity xlinux jdk11

This was referenced Dec 13, 2018
Closed
Merged
@AdamBrousseau
Set job variables for PR builds based on PR case not build case
0ae098f 
- Remove support for test cases since we no longer
  use our test pipelines (eclipse-openj9#1450)
- Set job variables for PullRequest builds based on PR case
  not build case. This avoids setting job properties for PR builds
  which removes the GH trigger configuration
- Remove test node labels as these are no longer in use

[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

Updated to remove test node labels from variable file.
Please review @vsebe

@AdamBrousseau AdamBrousseau mentioned this pull request Dec 19, 2018
Closed
vsebe
vsebe approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@vsebe vsebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AdamBrousseau AdamBrousseau mentioned this pull request Jan 15, 2019
Closed
@pshipton pshipton merged commit 50976f7 into eclipse-openj9:master Jan 19, 2019
This was referenced Jan 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@vsebe vsebe vsebe approved these changes

Assignees
No one assigned
Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamBrousseau @pshipton @vsebe