Avoid mishandling of immutable objects that escape in cold blocks #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fixupNode, force non-contiguous, immutable objects that escape in cold blocks to go through fixupFieldAccess processing to ensure the temporary that will replace it will be properly initialized. Then, in fixupFieldAccessForNonContiguousAllocation, ensure the store to the original object is preserved along with the store to the temporary that's being created to replace its field. The former will be needed if we escape, and the latter is needed if we don't escape. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
@vijaysun-omr Vijay, may I ask you to review this pull request? |
vijaysun-omr
approved these changes
Jan 14, 2019
|
Looks good to me @hzongaro The logic makes sense to keep both auto and field store when we have the special case of an immutable discontiguous allocation that escapes in the given block. |
|
Thanks, Vijay @vijaysun-omr , for all your guidance, help and advice in fixing this problem! |
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
Jenkins test sanity xlinux jdk11,jdk8 |
|
This is targeted for post- |
|
Can this be merged now? |
|
I believe so - I'm happy with this given the clean sanity and review from @vijaysun-omr. |
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fixupNode, force non-contiguous, immutable objects that escape in
cold blocks to go through fixupFieldAccess processing to ensure the
temporary that will replace it will be properly initialized.
Then, in fixupFieldAccessForNonContiguousAllocation, ensure the store
to the original object is preserved along with the store to the temporary
that's being created to replace its field. The former will be needed
if we escape, and the latter is needed if we don't escape.
Fixes: #4281
Signed-off-by: Henry Zongaro zongaro@ca.ibm.com