Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize allocation macros #4878

Merged
merged 1 commit into from Feb 28, 2019
Merged

Conversation

gacholio
Copy link
Contributor

Provide macros which describe their purpose rather than their literal
function (i.e. primitive or array). Add/rename macros to test for:

  • class uses totalInstanceSize for allocation

In this case, HCR slams the old class with a size which prevents any
possible allocation.

  • class can be allocated via the new bytecode

Value types are added to the mask preventing allocation via new.

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

@gacholio
Copy link
Contributor Author

gacholio commented Feb 26, 2019

This does not address what Class.newInstance() will mean for value types.

runtime/oti/j9modifiers_api.h Outdated Show resolved Hide resolved
runtime/vm/resolvesupport.cpp Show resolved Hide resolved
Provide macros which describe their purpose rather than their literal
function (i.e. primitive or array). Add/rename macros to test for:

- class uses totalInstanceSize for allocation

In this case, HCR slams the old class with a size which prevents any
possible allocation.

- class can be allocated via the new bytecode

Value types are added to the mask preventing allocation via new.

[ci skip]

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@gacholio
Copy link
Contributor Author

jenkins test all win jdk8

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga DanHeidinga merged commit d93c279 into eclipse-openj9:master Feb 28, 2019
@gacholio gacholio deleted the inst branch February 28, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants