CMake: rework platform handling in port library #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanHeidinga
reviewed
Mar 27, 2019
| @@ -31,33 +31,57 @@ | |||
|
|
|||
|
|
|||
| set(OBJECTS "") | |||
| list(APPEND OBJECTS | |||
| list(APPEND OBJECTS | |||
| j9gp.c | |||
There was a problem hiding this comment.
Can these lists be kept in alphabetical order?
There was a problem hiding this comment.
Sure, I just reordered so that it would match the module.xml. I'm assuming I should reorder that as well?
runtime/port/CMakeLists.txt
Outdated
|
|
||
| if(OMR_OS_ZOS) | ||
| list(APPEND OBJECTS | ||
| j9mprotect.s |
There was a problem hiding this comment.
alphabetize this list if possible
Clean up platform specific code as well as adding support for missed platforms Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
|
Jenkins compile zlinux,win,aix jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up platform specific code as well as adding support for missed
platforms
Signed-off-by: Devin Nakamura devinn@ca.ibm.com