Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed build instructions for OpenJDK8 #626

Merged
merged 1 commit into from Nov 20, 2017

Conversation

SueChaplain
Copy link
Contributor

Add markdown file for building OpenJDK8 with
OpenJ9 on Linux and AIX systems.

Add the yum text file that we reference in the
AIX build instructions.

Issue at github.com/eclipse-openj9/openj9-website/issues/25

[ci skip]

Issue #25

Signed-off-by: Sue Chaplain sue_chaplain@uk.ibm.com


2. This build uses the same gcc and g++ compiler levels as OpenJDK, which might be
backlevel compared with the versions you use on your system. Create links for
the compilers with the following command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be commands instead of command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

ln -s gcc-4.8 /usr/bin/gcc
```

3. Download and setup **freemarker.jar** into a directory. The example commands use `/root` to be consistent with the Docker instructions. If you aren't using Docker, you probably want to store the freemarker.jar in your home directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to highlight the second occurrence of freemarker.jar, similarly to the jdk9 instructions?


A number of RPM packages are also required. The easiest method for installing these packages is to use `yum`, because `yum` takes care of any additional dependent packages for you.

Download the following file: [yum_install_aix-ppc64.txt](aix/jdk9/yum_install_aix-ppc64.txt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be jdk8 instead of jdk9

@@ -0,0 +1,50 @@
# Copyright (c) 2017, 2017 IBM Corp. and others
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this file is the same as the jdk9 version (except for the V8 in the comment). Should we create a common directory like jdk8or9 to contain the common source and avoid having to update multiple files if something changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to keep them separate as we do for docker files.

Building OpenJDK Version 8 with OpenJ9
======================================

Our website describes a simple [build process](http://www.eclipse.org/openj9/oj9_build.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes the Java 9 simple build process. Is there an equivalent page for java 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same page for both versions. There is a toggle to flip between instructions for 8 or 9.

@SueChaplain
Copy link
Contributor Author

@pshipton I've addressed all the changes you requested.

Add markdown file for building OpenJDK8 with
OpenJ9 on Linux and AIX systems.

Add the yum text file that we reference in the
AIX build instructions.

Issue at github.com/eclipse-openj9/openj9-website/issues/25

[ci skip]

Issue eclipse-openj9#25

Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
:ledger:

:construction:
We haven't created a full build process for Windows yet? Watch this space!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent, but these would be great places to link to the issues opened to produce Windows, Macos, ARM, etc. builds...

Windows: #55
Macos: #36
ARM: #53 #66 #138

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v9 instructions could be updated similarly. I'll do both as an enhancement on a separate PR if that's ok?

@mstoodle
Copy link
Contributor

mstoodle commented Nov 20, 2017

lgtm Thanks @SueChaplain !

@pshipton pshipton merged commit 4a6ae1f into eclipse-openj9:master Nov 20, 2017
@SueChaplain SueChaplain deleted the buildv8 branch February 20, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants