Add enumerateFields api to create a TypeLayout object #6570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes depend on eclipse/omr#4157. |
andrewcraik
reviewed
Jul 24, 2019
andrewcraik
reviewed
Jul 24, 2019
|
Updated for review. |
Charlmzz
force-pushed
the
type-layout
branch
from
12dd23f
to
e12c2cb
Compare
andrewcraik
reviewed
Oct 9, 2019
andrewcraik
reviewed
Oct 9, 2019
andrewcraik
reviewed
Oct 9, 2019
andrewcraik
reviewed
Oct 9, 2019
andrewcraik
reviewed
Oct 17, 2019
|
@Charlmzz I think modulo a guarded traceMessage this should be good to go. When you add the trace can you please also rebase onto head? Your branch is now out of sync with the accepted OMR so there are build failures because of opcode table mismatches. The rebase will let the CI testing run to completion. |
|
@Charlmzz any update? |
An enumerateFields api is added to create a TypeLayout object based on given OpaqueClassBlock which iterates through each field to construct a TypeLayoutEntry that contains DataType, offset and field name information. Signed-off-by: Yiling Han <Yiling.Han@ibm.com>
andrewcraik
approved these changes
Oct 30, 2019
|
Jenkins test sanity all jdk8,jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An enumerateFields api is added to create a TypeLayout object based
on given OpaqueClassBlock which iterates through each field to
construct a TypeLayoutEntry that contains DataType, offset and
field name information.
Signed-off-by: Yiling Han Yiling.Han@ibm.com