Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VM code & setting for RISC-V in OpenJ9 (part6/VM) #7445

Merged
merged 1 commit into from Apr 23, 2020
Merged

Update VM code & setting for RISC-V in OpenJ9 (part6/VM) #7445

merged 1 commit into from Apr 23, 2020

Conversation

ChengJin01
Copy link
Contributor

The changes mainly update & add interpreter specific code
(with placeholders to be replaced by JIT) & setting
to enable on RISC-V 64bit from the OpenJ9 perspective.

Issue: eclipse#7421

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Oct 11, 2019 •
edited

Already verified the compilation on Fedora_Linux/QEMU.

Note: The JIT related code (on register setting) util/jitregs.c was written against the RISC-V Spec (please refer to https://content.riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf for details)
and should be modified by JIT to ensure it works correctly from JIT perspective.

In addition, rv64helpers.m4 & rv64cinterp.m4 should be updated by JIT later to insert JIT frames so
as to replace rv64cinterpnojit.cpp(the wrapper of interpreter for now without JIT)

Reviewer: @keithc-ca, @gacholio, @pshipton , @DanHeidinga

@ChengJin01 ChengJin01 mentioned this pull request Oct 11, 2019
Open
@ChengJin01 ChengJin01 force-pushed the riscv_openj9_part6_vm branch 2 times, most recently from 76cee58 to 5902be8 Compare October 18, 2019 16:38
keithc-ca
keithc-ca reviewed Feb 6, 2020
View reviewed changes
runtime/vm/module.xml Outdated Show resolved Hide resolved
keithc-ca
keithc-ca requested changes Feb 6, 2020
View reviewed changes
runtime/oti/j9nonbuilder.h Outdated Show resolved Hide resolved
runtime/oti/j9nonbuilder.h Outdated Show resolved Hide resolved
@keithc-ca keithc-ca self-assigned this Feb 6, 2020
@keithc-ca
Copy link
Contributor

@ChengJin01 Please resolve the merge conficts.

@ChengJin01 ChengJin01 force-pushed the riscv_openj9_part6_vm branch 3 times, most recently from 58994e8 to 68e1ec3 Compare February 18, 2020 18:18
@ChengJin01
Copy link
Contributor Author

@keithc-ca, the conflict has been fixed.

gacholio
gacholio reviewed Apr 15, 2020
View reviewed changes
runtime/vm/jvminit.c Outdated Show resolved Hide resolved
@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Apr 17, 2020 •
edited

@keithc-ca & @gacholio , I updated the code with bytecodeLoop accordingly to to avoid conflict with the split interpreter changes from @sharon-wang. Please double-check in case any issue is introduced.

@gacholio
Copy link
Contributor

The jvminit merge seems correct to me.

@sharon-wang
Copy link
Contributor

Agreed, bytecodeLoop updates look good!

@keithc-ca
Copy link
Contributor

@gacholio Please add your approval if you're satisfied with this.

@gacholio
Copy link
Contributor

jenkins test sanity zlinux jdk8

@gacholio
Copy link
Contributor

jenkins test sanity plinux jdk8

@ChengJin01
Update VM code & setting for RISC-V in OpenJ9 (part6/VM)
e74c691 
The changes mainly update & add interpreter specific code
(with placeholders to be replaced by JIT) & setting
to enable on RISC-V 64bit from the OpenJ9 perspective.

Issue: eclipse#7421

Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
@gacholio
Copy link
Contributor

I saw enough testing pass to prove there's no cross-platform issues, and the latest push was an obvious fix in a file only compiled on the new processor, so I'm merging this.

@gacholio gacholio merged commit 0f5fbb8 into eclipse-openj9:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

@gacholio gacholio gacholio approved these changes

Assignees

@keithc-ca keithc-ca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChengJin01 @keithc-ca @gacholio @sharon-wang