Merge JITServer changes to CompilationThread.cpp/hpp

[mpirvu]

Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com

[mpirvu]

Jenkins test sanity all jdk8,jdk11

[mpirvu]

Jenkins test sanity plinux jdk8,jdk11

[mpirvu]

@ymanton This is a relatively difficult PR to review because I did a little bit of restructuring. The vast majority of the changes are in CompilationThread.cpp though.

[mpirvu]

Jenkins test sanity aix jdk8,jdk11

[ymanton]

Most of it looks OK. My concentration started to fail in CompilationThread.cpp, but I'll try to give it one more pass later.

[mpirvu]

@ymanton I addressed all the review comments and pushed the new version.

[ymanton]

LGTM.

[ymanton]

Jenkins test sanity.functional all jdk8,jdk11

[mpirvu]

11:54:48  Compiling 4 files for BUILD_JIGSAW_TOOLS
11:54:48  Assertion failed at /home/jenkins/workspace/Build_JDK11_ppc64le_linux_Personal/build/linux-ppc64le-normal-server-release/vm/compiler/../compiler/control/CompilationThread.cpp:9789: comp
11:54:48  	comp object must always exist when calling compilationEnd

So, that test was not there for nothing. I wonder under what conditions we hit this.

[mpirvu]

So, looking at the code the JIT will call compilationEnd() to fail compilations it has no intent to compile. For instance, when purging the compilation queue because the JVM is shutting down, when all compilation threads are suspended or when we don't want to compile anymore (e.g. virtual address space is running low).

[ymanton]

It looks like the existing compilationEnd() checks for comp != NULL in some places to deal with this situation, but not all of the code is guarded. Its hard to tell if the unguarded code will really execute if we enter without a comp, but if it does execute the early check & return from the jitaas branch are going change the behaviour.

[mpirvu]

I updated the code to allow for the possibility of comp object being null when compilation was aborted/failed.

[ymanton]

Jenkins test sanity.functional all jdk8,jdk11

[mpirvu]

Jenkins test sanity.functional all jdk8,jdk11

[mpirvu]

Testing has passed.

[mpirvu]

More issues discovered in the jitaas branch. The entry can also be NULL in compilationEnd()

[mpirvu]

Jenkins test sanity all jdk8,jdk11

[mpirvu]

Jenkins test sanity zlinux jdk11

[mpirvu]

Jenkins test sanity win jdk8

[mpirvu]

Tests passed on all platforms except win64 which has some infra problem:

13:27:13  Testing: Test option -Xjit:count=0,disableZ13
13:27:13  Test start time: 2019/10/19 12:27:12 Central Standard Time
13:27:13  Running command: "C:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_windows_Personal/openjdkbinary/j2sdk-image\\bin\\java" -Xcompressedrefs  -Xdump -Xjit:count=0,disableZ13 -version
13:27:13  Time spent starting: 0 milliseconds
13:30:25  ***[TEST INFO 2019/10/19 12:30:12] ProcessKiller detected a timeout after 180000 milliseconds!***
13:30:25  INFO: getUnixPID() has failed indicating this is not a UNIX System.'Debug on timeout' is currently only supported on Linux.
13:30:25  Output from test:
13:30:25   [ERR] openjdk version "1.8.0_232-internal"
13:30:25   [ERR] OpenJDK Runtime Environment (build 1.8.0_232-internal-jenkins_2019_10_19_11_35-b00)
13:30:25   [ERR] Eclipse OpenJ9 VM (build HEAD-ebd657f54, JRE 1.8.0 Windows Server 2012 R2 amd64-64-Bit Compressed References 20191019_348 (JIT enabled, AOT enabled)
13:30:25   [ERR] OpenJ9   - ebd657f54
13:30:25   [ERR] OMR      - 148a6b09
13:30:25   [ERR] JCL      - 7eb1dfe231f based on jdk8u232-b09)
Cancelling nested steps due to timeout
23:18:30  Sending interrupt signal to process
23:18:50  After 20s process did not stop
23:18:50  jenkins.util.io.CompositeIOException: Unable to delete 'C:\Users\jenkins\workspace\Test_openjdk8_j9_sanity.functional_x86-64_windows_Personal@tmp\durable-e7bce985'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
23:18:50  	at jenkins.util.io.PathRemover.forceRemoveRecursive(PathRemover.java:99)
23:18:50  	at hudson.Util.deleteRecursive(Util.java:293)
23:18:50  	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1274)

[ymanton]

LGTM.