-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GC Mappings #7723
Add GC Mappings #7723
Conversation
See Issue #4930 |
FYI @dmitripivkine |
please squash commits to one |
This commit maps the following Hotspot options: -XX:ParallelCMSThreads=N to -XconcurrentbackgroundN -XX:ConcGCThreads=N to -XconcurrentbackgroundN -XX:ParallelGCThreads=N to -XgcthreadsN Signed-off-by: AlenBadel <Alen.Badel@ibm.com>
@DanHeidinga Could you kindly take a quick look? I know you had concerns earlier if GC options should be mapped with |
@DanHeidinga Could you kindly take a look? This is slated for R0.18 |
@DanHeidinga could you review please? |
@gacholio I think @DanHeidinga is very busy, maybe you can take a look? This PR is holding the rest of the option migration work which we really want to get into 0.18. |
@pshipton Feel free to chime in. I know you're quite versed with past options migrations and mapping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jenkins test sanity plinux,zlinux,win jdk8 |
Is there a doc PR created for this? |
Not sure what's up with the breakage in the PR testing, checking with Adam. |
Should be fixed now by #8010 Jenkins test sanity plinux,zlinux,win jdk8 |
I forgot, I think the commit needs to be rebased in order to fix the PR testing. |
Well apparently not, because the PR tests are running. |
No, but I just created an issue for it. |
@AlenBadel note you also need to create the doc PR. The docs team will review but doesn't create the doc changes any more. See https://github.com/eclipse/openj9-docs/tree/master/process |
@pshipton can we merge this PR so that @AlenBadel can proceed with the next one that is dependent on it? |
The reviewers approved and the PR testing has passed, so I'll go ahead and merge. |
This commit maps the following Hotspot options:
-XX:ParallelCMSThreads=N to -XconcurrentbackgroundN
-XX:ConcGCThreads=N to -XconcurrentbackgroundN
-XX:ParallelGCThreads=N to -XgcthreadsN
Doc PR eclipse-openj9/openj9-docs#464
Signed-off-by: AlenBadel Alen.Badel@ibm.com