Fix JNI performance regression #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to check in OpenJ9 side refactoring first before OMR side fix can be check in. It was caused by changes committed for OpenJ9 issue eclipse-openj9#4893. When JNILinkage is not set on the method symbol anymore, OutOfLine performCall eventully evaluated it through PrivateLinkage and stuck in interpreter. The fundamental reason is that a new node is created for performCall but the isPreparedForJNI flag is not copied over and performCall doesn't get the linkage right. Signed-off-by: Julian Wang <zlwang@ca.ibm.com>
|
@DanHeidinga take this forward? |
Sorry @zl-wang, I'm not clear on what your asking for here. I'm not the right person to review this (@gita-omr maybe?) but if you're asking if we should fix a JNI performance issue, I don't see why we wouldn't. What am I missing here? |
|
I would ask @0xdaryl to review then. |
|
Jenkins test sanity plinux,aix jdk11 |
|
@0xdaryl moving forward? |
0xdaryl
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check in OpenJ9 side refactoring first before OMR side fix can be check
in.
It was caused by changes committed for OpenJ9 issue #4893. When JNILinkage is not
set on the method symbol anymore, OutOfLine performCall eventully evaluated it
through PrivateLinkage and stuck in interpreter. The fundamental reason is that
a new node is created for performCall but the isPreparedForJNI flag is not copied
over and performCall doesn't get the linkage right.
Signed-off-by: Julian Wang zlwang@ca.ibm.com