Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7871 Remove getVMThreadStatus_DEPRECATED function #7952

Merged
merged 1 commit into from Dec 5, 2019

Conversation

sbcd90
Copy link
Contributor

@sbcd90 sbcd90 commented Dec 3, 2019

No description provided.

@DanHeidinga
Copy link
Member

@sbcd90 Thanks for creating this PR! The change looks good overall and to be able to accept it, you'll need to sign the Eclipse Contributor Agreement (ECA).

Currently, the eclipsefdn/eca automated checker is failing - see details https://accounts.eclipse.org/legal/eca/validation/20838

Can you update the commit with the correct sign-off by tags after signing the ECA? Once that's passing, we can get the change built and take the next steps

@sbcd90
Copy link
Contributor Author

sbcd90 commented Dec 4, 2019

Hi @DanHeidinga , Thanks for your comments. I have signed eca now.
Kindly let me know if i need to do anything further.

@DanHeidinga
Copy link
Member

Thanks @sbcd90! The automated copyright checker is failing on these files:

01:34:42  runtime/tests/thread/thrstate/testcases1.c
01:34:42  runtime/tests/thread/thrstate/testcases2.c
01:34:42  runtime/tests/thread/thrstate/testcases3.c
01:34:42  runtime/tests/thread/thrstate/testcases4.c
01:34:42  runtime/tests/thread/thrstate/testcases5.c
01:34:42  runtime/tests/thread/thrstate/testcases6.c
01:34:42  runtime/tests/thread/thrstate/testsetup.c
01:34:42  runtime/tests/thread/thrstate/thrstatetest.h

and needs the second year in the comment at the top of the file to be updated to the current year.

So for example, * Copyright (c) 1991, 2018 --> * Copyright (c) 1991, 2019

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90
Copy link
Contributor Author

sbcd90 commented Dec 5, 2019

Hi @DanHeidinga , thanks for your inputs. I fixed all build failures now.

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux,osx,win jdk8

@DanHeidinga DanHeidinga self-assigned this Dec 5, 2019
@DanHeidinga
Copy link
Member

Thanks @sbcd90. Once the PR testing completes, I'll merge this

@DanHeidinga DanHeidinga merged commit 7a43d45 into eclipse-openj9:master Dec 5, 2019
@DanHeidinga
Copy link
Member

thanks @sbcd90 - your PR has been merged now! Congrats on your first contribution to OpenJ9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants