Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing barriers to jProfiling helpers #7964

Merged

Commits on Dec 3, 2019

  1. Add missing barriers to jProfiling helpers

    Previously, the tryLock and unlock methods on the jProfiling hash table
    implementation did not contain any read or write barriers. While this is
    fine on architectures such as x86-64, this causes problems with the weak
    memory model used in Power. Failing to include the barriers could allow
    reordering of memory accesses to cause incorrect behaviour with
    unpredictable results.
    
    Signed-off-by: Ben Thomas <ben@benthomas.ca>
    aviansie-ben committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    33c3666 View commit details
    Browse the repository at this point in the history