Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CFG Simplifier #8028

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Enable CFG Simplifier #8028

merged 1 commit into from
Jan 23, 2020

Conversation

Charlmzz
Copy link
Contributor

@Charlmzz Charlmzz commented Dec 9, 2019 •
edited

Turn CFG simplifier back on as a bug exposed has been fixed
in #8006 .

Signed-off-by: Yiling Han Yiling.Han@ibm.com

Enable CFG Simplifier
ed96ff0 
Signed-off-by: Yiling Han <Yiling.Han@ibm.com>
@Charlmzz Charlmzz changed the title Enable CFG Simplifier WIP: Enable CFG Simplifier Dec 9, 2019
@andrewcraik andrewcraik self-assigned this Dec 10, 2019
@Charlmzz Charlmzz changed the title WIP: Enable CFG Simplifier Enable CFG Simplifier Dec 11, 2019
@andrewcraik
Copy link
Contributor

Jenkins test sanity all jdk8

andrewcraik
andrewcraik approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@andrewcraik andrewcraik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests passing

@Charlmzz Charlmzz changed the title Enable CFG Simplifier WIP: Enable CFG Simplifier Dec 11, 2019
@andrewcraik
Copy link
Contributor

We need to disable use of ternary on arm/other platforms without evaluators

@Charlmzz Charlmzz changed the title WIP: Enable CFG Simplifier Enable CFG Simplifier Dec 17, 2019
@Charlmzz
Copy link
Contributor Author

Ternary disabled on arm/other platforms in eclipse/omr#4681. Removing WIP for this PR.

@andrewcraik
Copy link
Contributor

Need to wait for OMR 4681 to merge before this can go in.

@fjeremic
Copy link
Contributor

The OMR change has just been merged. Should promote by EOD or tomorrow.

@andrewcraik
Copy link
Contributor

Jenkins test sanity all jdk8

@andrewcraik andrewcraik merged commit a055a16 into eclipse-openj9:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewcraik andrewcraik andrewcraik approved these changes

Assignees

@andrewcraik andrewcraik

Labels
comp:jit depends:omr enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Charlmzz @andrewcraik @fjeremic