Common getOffsetToFirstParm and mapIncomingParms in the linkage class across codegens #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on eclipse/omr#4798. |
fjeremic
commented
Jan 31, 2020
fjeremic
force-pushed
the
document-private-linkage-double-slot
branch
2 times, most recently
from
dcbc29e
to
118eebd
Compare
|
Jenkins test sanity all jdk8 depends eclipse/omr#4798 |
|
Jenkins test sanity xlinuxxl,win32,zlinux,plinux jdk8 depends eclipse/omr#4798 |
0xdaryl
reviewed
May 5, 2020
fjeremic
force-pushed
the
document-private-linkage-double-slot
branch
from
d4fe381
to
ddb436d
Compare
|
I also rebased to resolve the conflicts. Jenkins test sanity all jdk8 depends eclipse/omr#4798 |
0xdaryl
approved these changes
May 7, 2020
|
Ugh. Sorry--a PR of mine was recently merged which now causes merge conflicts with this one. Would you mind resolving? |
This API has a semantically equivalent implementation on all codegens. Given private linkage is platform agnostic it makes sense of this API to live in the common private linkage class. We also take this opportunity to document why we double the stack slot size in certain scenarios. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
The `getOffsetToFirstParm` API currently belongs to linkage properties class in each codegen, with the Z codegen being the exception having it inside of the Z specific `OMRLinkage`. This API is however used throughout all codegens and can belong to the common code `OMRLinkage` class. We migrate the API there for use in downstream projects. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Using `self()` within constructors relies on undefined behaviour and should be avoided. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Calls to `self()` in private linkage classes are not needed because these classes are not extensible. We also take this opportunity to version a check for 64-bit in the `mapIncomingParms` function. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic
force-pushed
the
document-private-linkage-double-slot
branch
from
ddb436d
to
6f09870
Compare
|
Jenkins test sanity all jdk8 depends eclipse/omr#4798 |
|
Jenkins test sanity all jdk8,jdk11 depends eclipse/omr#4798 |
|
Jenkins test sanity.functional xlinuxxl jdk11 depends eclipse/omr#4798 |
|
I have run the OMR promotion tests successfully and manually promoted the corresponding OMR change. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getOffsetToFirstParmAPI currently belongs to linkage propertiesclass in each codegen, with the Z codegen being the exception having it
inside of the Z specific
OMRLinkage. This API is however usedthroughout all codegens and can belong to the common code
OMRLinkageclass. We migrate the API there for use in downstream projects.
The
mapIncomingParmsAPI has a semantically equivalent implementationon all codegens. Given private linkage is platform agnostic it makes sense
of this API to live in the common private linkage class. We also take this
opportunity to document why we double the stack slot size in certain
scenarios.
Closes: #8360
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com