Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace JITSERVER_SUPPORT with J9VM_OPT_JITSERVER #8656
Replace JITSERVER_SUPPORT with J9VM_OPT_JITSERVER #8656
Changes from 1 commit
b9c1fd8
c5f120f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need these defines? Are the definitions added in some other place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is for defining the macro
JITSERVER_SUPPORT
. We should instead useJ9VM_OPT_JITSERVER
which gets defined inj9cfg.h
(when using UMA build system) or byCMakeLists.txt
in VM and JIT.Normally
j9cfg.h
gets included viaj9.h
and any code usingJ9VM_OPT_JITSERVER
should now includej9.h
.Before this PR, JIT files didn't include
j9.h
if there isn't any dependency on it, but with this PR if the JIT files need to seeJ9VM_OPT_JITSERVER
, thenj9.h
needs to be included.A case in point is https://github.com/eclipse/openj9/pull/8656/files#diff-65a548d2a6dcefcbcdd234568cac76ab where I have to explicitly include
j9.h
.