-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Jcmd dump with default settings #8744
Conversation
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
lgtm, it's worth extending the test suite though. |
jenkins compile zlinux jdk11 |
I tried the existing TestJcmd_0 test using a grinder, and it's failing.
|
It is an |
Modified/added the test, and passed locally. |
DiagnosticUtils.triggerDumpsImpl() can generate dump files with default settings when the dump request doesn't have `:file=name`, modified the request string according to the incoming arguments; Modified Jcmd help message; Modified the test to adopt Jcmd without command argument; Added a test for Jcmd with default settings; Minor refactoring. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
jenkins test extended win,plinux jdk8,jdk11 |
@JasonFengJ9 we should mention this change in the User Guide What's New. Pls create a docs Issue, and later a PR. The docs aren't open for 0.20.0 changes yet, but should be later this week. |
Support Jcmd dump with default settings
DiagnosticUtils.triggerDumpsImpl()
can generate dump files with default settings when the dump request doesn't have:file=name
, modified the request string according to the incoming arguments.Modified
Jcmd
help message;Modified the test to adopt
Jcmd
without command argument;Added a test for
Jcmd
with default settings;Minor refactoring.
closes: #8721
Reviewer: @DanHeidinga
FYI: @pshipton
Signed-off-by: Jason Feng fengj@ca.ibm.com