Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn interp_useUnsafeHelper on for aarch specs #8996

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Turn interp_useUnsafeHelper on for aarch specs #8996

merged 2 commits into from
Mar 27, 2020

Conversation

DanHeidinga
Copy link
Member

This is required to allow the VM to intercept bus errors
and convert them into InternalErrors

Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com

@DanHeidinga
Turn interp_useUnsafeHelper on for aarch specs
1deeb99 
This is required to allow the VM to intercept bus errors
and convert them into InternalErrors

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@DanHeidinga
Copy link
Member Author

Note, I haven't tested this as I don't have an aarch64 box around. It's more to indicate the place where this would need to be enabled.

@DanHeidinga DanHeidinga mentioned this pull request Mar 26, 2020
Closed
@DanHeidinga
Fix copyright dates
9fe31df 
Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@knn-k
Copy link
Contributor

knn-k commented Mar 26, 2020

This seem to solve the crash with java/nio/MappedByteBuffer/Truncate (#8970), using my local build. It throws an InternalError instead of crashing.

java.lang.InternalError: SIGBUS
        at java.base/jdk.internal.misc.Unsafe.getByte(Native Method)
        at java.base/jdk.internal.misc.Unsafe.getByte(Unsafe.java:1019)
        at java.base/java.nio.MappedByteBuffer.load(MappedByteBuffer.java:174)
        at Truncate$2.call(Truncate.java:70)
        at Truncate$2.call(Truncate.java:68)
        at Truncate$3.run(Truncate.java:85)
        at java.base/java.lang.Thread.run(Thread.java:834)
STATUS:Passed.

I don't remember why I didn't put the interp_useUnsafeHelper line in AArch64 specs.

@knn-k
Copy link
Contributor

knn-k commented Mar 26, 2020

jenkins test sanity alinux64 jdk11

@knn-k knn-k self-assigned this Mar 26, 2020
@knn-k
Copy link
Contributor

knn-k commented Mar 26, 2020

The changes look good to me.

@knn-k
Copy link
Contributor

knn-k commented Mar 27, 2020

Sanity test passed.

@knn-k knn-k merged commit 49751e3 into eclipse-openj9:master Mar 27, 2020
@knn-k
Copy link
Contributor

knn-k commented Mar 27, 2020

@DanHeidinga Would you open a PR for v0.20.0, please? Thanks.

@DanHeidinga DanHeidinga mentioned this pull request Mar 27, 2020
Merged
@DanHeidinga
Copy link
Member Author

@DanHeidinga Would you open a PR for v0.20.0, please? Thanks.

Opened #9000

@DanHeidinga DanHeidinga deleted the djh/aarchUnsafe branch March 27, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knn-k knn-k knn-k approved these changes

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl

Assignees

@knn-k knn-k

Labels
arch:aarch64 comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanHeidinga @knn-k