Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce CompInfo_isCompiled message from the server #9160

Merged
merged 1 commit into from Apr 8, 2020

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Apr 7, 2020

One frequent path on which the server sends CompInfo_isCompiled message is in ClientSessionData::cacheIProfilerInfo(). On this path, we could combine the message into other two messages: IProfiler_setCallCount and IProfiler_profilingSample.

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

One frequent path on which the server sends CompInfo_isCompiled
message is in ClientSessionData::cacheIProfilerInfo().
On this path, we could combine the message into other two
messages: IProfiler_setCallCount and IProfiler_profilingSample.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo changed the title WIP: Reduce CompInfo_isCompiled message from the server Reduce CompInfo_isCompiled message from the server Apr 7, 2020
@a7ehuo a7ehuo marked this pull request as ready for review April 7, 2020 23:49
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Apr 8, 2020
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Apr 8, 2020
@mpirvu mpirvu self-assigned this Apr 8, 2020
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Apr 8, 2020

jenkins test sanity plinuxjit,xlinuxjit jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Apr 8, 2020

With a debug build, ran into asserts related to the cache "Should not have cached unresolved method globally".

I don't remember to have seen that assert before.

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Apr 8, 2020

Sorry, I posted the comment in the wrong window. That was supposed to be posted to #9174. I just deleted the comment in this PR. The comment should be gone if this page is refreshed.

@mpirvu mpirvu merged commit 5c46748 into eclipse-openj9:master Apr 8, 2020
JIT as a Service automation moved this from In progress to Done Apr 8, 2020
@a7ehuo a7ehuo deleted the reduce-iscompiled branch May 1, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants