Collect stats about sizes of different types of messages sent in JITServer #9752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanElsaban
changed the title
|
@mpirvu Can you please review my PR? Thank you. |
mpirvu
requested changes
Jun 1, 2020
mpirvu
requested changes
Jun 3, 2020
mpirvu
reviewed
Jun 5, 2020
mpirvu
reviewed
Jun 5, 2020
EmanElsaban
force-pushed
the
collectStats
branch
2 times, most recently
from
25e3599
to
bc03e03
Compare
mpirvu
reviewed
Jun 5, 2020
I'm keeping track of the size of different types of messages sent using msg.type() and I'm using the class TR_Stats to store avg,min,max and stddev of every type of message. I declared a static array in CommunicationStream.hpp and I'm using that to store in. issue: eclipse-openj9#9708 Signed-off-by: Eman Elsabban <eman.elsaban1@gmail.com>
|
jenkins test sanity plinuxjit jdk11 |
|
@EmanElsaban Would be able to run this code through some benchmark (AcmeAir would be a good choice) and collect the statistics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm keeping track of the size of different types of messages sent using msg.type()
and I'm using the class TR_Stats to store avg,min,max and stddev of every type of message.
issue: #9708
Signed-off-by: Eman Elsabban eman.elsaban1@gmail.com