Revert "Revert "Mark VM as exitting earlier"" #9864
Conversation
|
@gacholio what's going on, this change introduces hang on exit problems for all platforms. |
|
It only affects a single test (on every platform, not just windows), and the fix is coming in a PR in a few minutes. There was no need to re-review the existing code. |
|
ok, but there is a timing hole here. If the new PR doesn't get merged today then the problem gets re-exposed in the builds tonight and on the weekend. The better approach is to include the "revert revert" commit in the new PR, separately from the latest fix commit, so they are merged together. Keeping it separated in two commits allows the reviewer to only look at the latest fix. |
|
I was unable to figure out how to do that. This change was in the builds for a week before the problem was detected, so there's no issue with having it in for a short while unfixed. |
|
In Eclipse, make local branch, open the history, find the revert commit and select revert on it to create a new commit in your local branch. Then make the changes on top in a new commit as usual. |
|
Thanks, I'll keep it in mind for the next time. |
|
I believe the problem causes some timeouts in the builds running at AdoptOpenJDK (not sure why not at OpenJ9). They weren't noticed until triaging for the 0.21 release Milestone 1, the revert didn't make M1. My point is that now Adopt nightly builds may be failing again until the fix is reviewed and merged. |
Reverts #9829