Modified printJITServerMsgStats to print at shutdown on server #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanElsaban
changed the title
|
@mpirvu Can you please review my PR? Thank you |
mpirvu
requested changes
Jun 17, 2020
| #endif | ||
| } | ||
| } | ||
| j9tty_printf(PORTLIB, "Total number of messages: %u\n", totalMsgCount); |
There was a problem hiding this comment.
If MESSAGE_SIZE_STATS is not defined, the for loop above will go over all the messages, but print nothing and at the very end it will print "Total number of messages: 0"
I would include the for loop and this last printf message into the block protected by ifdef.
Also, add a comment to the #endif so that we know what should be paired with:
#if defined(MESSAGE_SIZE_STATS)
...
#endif // defined(MESSAGE_SIZE_STATS)
To trigger the jitDump use the option -Xdump:jit:events=user from the server side and then run the Java client and then kill -3 <pidof jitserver>. This will print the message stats received by the server at shutdown. issue: eclipse-openj9#9708 Signed-off-by: Eman Elsabban <eman.elsaban1@gmail.com>
|
jenkins test sanity plinuxjit,xlinuxjit jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To trigger the jitDump use the option
-Xdump:jit:events=userfrom the server sideand then run the Java client and then
kill -3 (pidof jitserver). This will printthe message stats received by the server at shutdown.
issue: #9708
Signed-off-by: Eman Elsabban eman.elsaban1@gmail.com