Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: silence warning about ignored return value #9937

Merged
merged 1 commit into from Jun 18, 2020

Conversation

dnakamura
Copy link
Contributor

Here the read/writes are used as a synchronization method, and there
really isn't much we can do if they fail

Signed-off-by: Devin Nakamura devinn@ca.ibm.com

Here the read/writes are used as a synchronization method, and there
really isn't much we can do if they fail

Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - matches convention of other write() calls that have the same issue

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux,zlinux jdk8

@DanHeidinga DanHeidinga self-assigned this Jun 18, 2020
@DanHeidinga DanHeidinga merged commit 84f004b into eclipse-openj9:master Jun 18, 2020
@pshipton
Copy link
Member

@dnakamura this change is causing builds using xlc to fail to compile. I'm going to revert it for now.

common/ut_j9prt.c

"/usr/include/linux/kernel.h", line 46.9: 1506-312 (W) Compiler internal name __FUNCTION__ has been defined as a macro.
"/usr/include/linux/kernel.h", line 46.9: 1506-236 (W) Macro name __FUNCTION__ has been redefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants