(0.21.0) Disable vectorization of induction variable #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoSIMD was generating incorrect IL due to the side effect of node commoning. Upon investigating further it was clear that to come up with a general solution, it would require time. Moreover, it appears that even for correct IL, AutoSIMD was failing in functionality tests. This suggest that there may be bug in the codegen as well. Thus, it was decided that for such cases, AutoSIMD will be disabled until a generalized solution is ready. This kind of optimization is currently available only in z Systems. and does not affect amd64 / powerpc. For more details see #eclipse/openj9/9446 Signed-off-by: Mohammad Nazmul Alam <mohammad.nazmul.alam@ibm.com>
|
@gita-omr @IBMJimmyk @pshipton This PR is a double-delivery of #9947. Let me know if anything needs to be updated. |
mnalam-p
changed the title
pshipton
approved these changes
Jun 22, 2020
mnalam-p
deleted the
disable_auto_simd_for_commoned_piv_usage-v0.21.0-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoSIMD was generating incorrect IL due to the side effect of node
commoning. Upon investigating further it was clear that to come up with
a general solution, it would require time. Moreover, it appears that even
for correct IL, AutoSIMD was failing in functionality tests.
This suggest that there may be bug in the codegen as well. Thus, it was
decided that for such cases, AutoSIMD will be disabled until a generalized
solution is ready.
This kind of optimization is currently available only in z Systems. and
does not affect amd64 / powerpc.
For more details see #eclipse/openj9/9446
Signed-off-by: Mohammad Nazmul Alam mohammad.nazmul.alam@ibm.com