Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Add dash license check to CI pipeline #16

Closed
wants to merge 1 commit into from
Closed

Conversation

jonahgraham
Copy link
Contributor

Adapted from @ruspl-afed's contribution in
eclipse-cdt/cdt#386

With Orbit being rather large, there are a number of outstanding issues that means this won't successfully complete automatically, so I don't know whether to submit it. I don't know where or how to store the exclusions.

See eclipse/dash-licenses#233 and https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/5372#note_1052111 for a couple of examples of where things don't line up.

@HannesWell
Copy link

@jonahgraham eclipse/dash-licenses#235 was merged, so it should work now only with the first commit.

@HannesWell
Copy link

/request-license-review

@HannesWell
Copy link

/request-license-review

Once this is merged, you can use this command to create requests to review the licenses of the unvetted dependencies.
This requires a Eclipse GITLAP API token. I see you have referenced one and assume you already have asked to IP team to include one.
From the initial comment I read that the situation is currently difficult regarding license vetting.

@jonahgraham
Copy link
Contributor Author

The check is now working as expected, the license errors being only:

  • [INFO] maven/mavencentral/com.sun.media/jai-codec/1.1.3
  • [INFO] maven/mavencentral/javax.media/jai-core/1.1.3

which are indeed errors and waiting on #17 to be fixed to resolve.

@jonahgraham
Copy link
Contributor Author

With the new work being undertaken in https://github.com/eclipse-orbit/orbit-simrel and little to no new commits planned in this repo, investing time in adding license checks here is no longer planned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants